From: Felipe Borges Date: Thu, 15 Dec 2022 10:56:54 +0000 (+0100) Subject: search: Stop special-casing GNOME Settings on search X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~201 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=0be20aba889efbde937562caf2c3b5a148a727f0;p=gnome-shell.git search: Stop special-casing GNOME Settings on search See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1282#note_1617502 From the chat: i think it's fine to allow people to disable settings search. the issue i see here is that the shell doesn't follow the search results order. settings is always at the top of the results list if settings search is to appear in the list, then that should work as you'd expect We are also removing the special-casing in the GNOME Settings side, see https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1555 Part-of: --- diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js index cef6f9cd3..592dfe199 100644 --- a/js/ui/remoteSearch.js +++ b/js/ui/remoteSearch.js @@ -144,9 +144,6 @@ function loadRemoteSearchProviders(searchSettings) { let sortOrder = searchSettings.get_strv('sort-order'); - // Special case gnome-control-center to be always active and always first - sortOrder.unshift('org.gnome.Settings.desktop'); - const disabled = searchSettings.get_strv('disabled'); const enabled = searchSettings.get_strv('enabled');